fix: memstats new stat should reuse measurement #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvrach
changed the title
achettyiitr
approved these changes
Jun 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found this issue while writing tests for a histogram metric. I did expect to receive 20 measurements for a metric, but instead I got only one.
It turns out that since a new stat was created every time, the measurement was getting overridden.
Note that this might have a breaking behaviour downstream, but tests that use
.GetAllor.GetByNameshould have and test all measurements captured.Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1161/fix-memstats-bug
resolves PIPE-1161
Security